professional-service-best-practices/professional-service
19
1
Fork 0
Code Issues Pull requests 2 Projects Releases Packages Wiki Activity Actions

fix(cloud-init): removed license headers from cloud-init.yaml files #41

Closed
tim.reibe wants to merge 1 commit from fix/cloud-init into main
pull from: fix/cloud-init
merge into: professional-service-best-practices:main
Conversation 4 Commits 1 Files changed 7 -98
tim.reibe commented 2026-06-25 16:55:18 +00:00
Owner
Copy link

Description

The first line of a cloud-init.yaml MUST contain #cloud-config. Otherwise, it does not get interpreted by cloud-init.
Source: https://docs.cloud-init.io/en/25.1/explanation/about-cloud-config.html#how-do-i-create-a-cloud-config-file

Checklist

  • The CI pipeline passed successfully.
## Description The first line of a `cloud-init.yaml` **MUST** contain `#cloud-config`. Otherwise, it does not get interpreted by cloud-init. Source: https://docs.cloud-init.io/en/25.1/explanation/about-cloud-config.html#how-do-i-create-a-cloud-config-file ## Checklist - [ ] The CI pipeline passed successfully.
tim.reibe added 1 commit 2026-06-25 16:55:19 +00:00
fix(cloud-init): removed license headers from cloud-init.yaml files
Some checks failed
Default CI / Check for Open TODOs (pull_request) Successful in 25s
Details
Default CI / Secret Scanner (TruffleHog) (pull_request) Successful in 49s
Details
Default CI / Pre-Commit Hooks (pull_request) Failing after 1m29s
Details
6a4a454090
requested review from sven.schmidt 2026-06-26 05:41:04 +00:00
sven.schmidt approved these changes 2026-06-26 05:41:57 +00:00
sven.schmidt left a comment
Owner
Copy link

Nice finding and good to know!

Nice finding and good to know!
sven.schmidt commented 2026-06-26 05:51:27 +00:00
Owner
Copy link

Should the pre-commit hook be adjusted as well?

@mauritz.uphoff @tim.reibe

Should the pre-commit hook be adjusted as well? @mauritz.uphoff @tim.reibe
mauritz.uphoff commented 2026-06-26 06:57:27 +00:00
Owner
Copy link

Adjusted the pre-commit in #42

Adjusted the pre-commit in https://professional-service.git.onstackit.cloud/professional-service-best-practices/professional-service/pulls/42
tim.reibe commented 2026-06-26 08:42:00 +00:00
Author
Owner
Copy link

Duplicate #42

Duplicate #42
tim.reibe closed this pull request 2026-06-26 08:42:01 +00:00
Some checks failed
Default CI / Check for Open TODOs (pull_request) Successful in 25s
Details
Default CI / Secret Scanner (TruffleHog) (pull_request) Successful in 49s
Details
Default CI / Pre-Commit Hooks (pull_request) Failing after 1m29s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
sven.schmidt
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: professional-service-best-practices/professional-service#41
No description provided.
Delete branch "fix/cloud-init"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?