fix/observability-log-alloy #79

Merged
mauritz.uphoff merged 2 commits from fix/observability-log-alloy into main 2026-09-25 06:06:35 +00:00
Owner

adjusted observabilty example

adjusted observabilty example
fix(ske): refactor observability logs with alloy | adjust agents.md
All checks were successful
AI PR Review / AI PR Review (pull_request) Successful in 51s
Default CI / Check for Open TODOs (pull_request) Successful in 51s
Default CI / Check README Tags (pull_request) Successful in 1m7s
Default CI / Check AGENTS.md is up to date (pull_request) Successful in 1m2s
Default CI / Pre-Commit Hooks (pull_request) Successful in 2m32s
9c2707ae9a

πŸ€– AI PR Review

9c2707ae Β· STACKIT Model Serving

βœ… πŸ“ Spelling & Grammar
πŸ€– STACKIT Model Serving

βœ… No spelling or grammar issues found.

⚠️ πŸ—οΈ Infrastructure Changes
πŸ€– STACKIT Model Serving
  • ⚠️ Deletes existing SKE cluster and kubeconfig resources (020-ske-cluster.tf) β€” this will destroy the cluster and its data.
  • ⚠️ Deletes Promtail Helm release and monitoring namespace (040-promtail.tf) β€” removes log collection from the cluster.
  • Creates new SKE cluster with dynamic Kubernetes and OS versions, using variables for configuration (030-ske-cluster.tf).
  • Creates new Observability instance with alert config using variable for email (040-observability.tf).
  • Creates new Alloy Helm release with secure credential handling via Kubernetes Secret (050-alloy.tf).
  • Creates new log alert group with variable-based namespace (060-log-alertgroup.tf).
  • Creates new example workload namespace and pod with variable-based namespace (070-example-workload.tf).
  • Adds variables for flexible configuration (020-variables.tf).
  • Updates provider versions to newer releases (010-provider.tf).
# To avoid destructive deletion, rename the old cluster resources instead of deleting them
resource "stackit_ske_cluster" "example_old" {
  # ... keep old config but rename resource
}

resource "stackit_ske_kubeconfig" "example_old" {
  # ... keep old config but rename resource
}

# Then create the new cluster under a new name or with updated config
resource "stackit_ske_cluster" "example" {
  # ... new config using variables
}
βœ… πŸ”’ Security Review
πŸ€– STACKIT Model Serving

βœ… No security issues found.

βœ… πŸ“ Example Consistency
πŸ€– STACKIT Model Serving

βœ… Example follows repository conventions.

βœ… πŸ“š Example README
πŸ€– STACKIT Model Serving

βœ… Example READMEs are complete.

⚠️ πŸ’¬ Commit Messages
πŸ€– STACKIT Model Serving
  • "fix(ske): refactor observability logs with alloy | adjust agents.md" β†’ Suggest: "Refactor SKE observability logs to use Alloy and update agents.md documentation"
  • "fix(ske): refactor observability logs with alloy" β†’ Suggest: "Refactor SKE observability logging to integrate Alloy for improved metrics and tracing"
βœ… 🏷️ Tag Quality
πŸ€– STACKIT Model Serving
  • The tag promtail in the README.md should be replaced with alloy to accurately reflect the current log shipping agent used.
  • The tag list is otherwise accurate and covers the STACKIT products (ske, observability) and key technologies (logging, alerting, kubernetes).
  • All tags are lowercase and hyphen-separated.

βœ… README tags accurately reflect the content.


Generated automatically β€” treat as a hint, not a gate.

## πŸ€– AI PR Review > [`9c2707ae`](https://professional-service.git.onstackit.cloud/professional-service-best-practices/professional-service/commit/9c2707ae9a5afe1830458ac6ebc217f1a93244e0) Β· STACKIT Model Serving <details> <summary>βœ… πŸ“ Spelling & Grammar</summary> <details> <summary>πŸ€– STACKIT Model Serving</summary> βœ… No spelling or grammar issues found. </details> </details> <details> <summary>⚠️ πŸ—οΈ Infrastructure Changes</summary> <details> <summary>πŸ€– STACKIT Model Serving</summary> - ⚠️ Deletes existing SKE cluster and kubeconfig resources (020-ske-cluster.tf) β€” this will destroy the cluster and its data. - ⚠️ Deletes Promtail Helm release and monitoring namespace (040-promtail.tf) β€” removes log collection from the cluster. - Creates new SKE cluster with dynamic Kubernetes and OS versions, using variables for configuration (030-ske-cluster.tf). - Creates new Observability instance with alert config using variable for email (040-observability.tf). - Creates new Alloy Helm release with secure credential handling via Kubernetes Secret (050-alloy.tf). - Creates new log alert group with variable-based namespace (060-log-alertgroup.tf). - Creates new example workload namespace and pod with variable-based namespace (070-example-workload.tf). - Adds variables for flexible configuration (020-variables.tf). - Updates provider versions to newer releases (010-provider.tf). ```hcl # To avoid destructive deletion, rename the old cluster resources instead of deleting them resource "stackit_ske_cluster" "example_old" { # ... keep old config but rename resource } resource "stackit_ske_kubeconfig" "example_old" { # ... keep old config but rename resource } # Then create the new cluster under a new name or with updated config resource "stackit_ske_cluster" "example" { # ... new config using variables } ``` </details> </details> <details> <summary>βœ… πŸ”’ Security Review</summary> <details> <summary>πŸ€– STACKIT Model Serving</summary> βœ… No security issues found. </details> </details> <details> <summary>βœ… πŸ“ Example Consistency</summary> <details> <summary>πŸ€– STACKIT Model Serving</summary> βœ… Example follows repository conventions. </details> </details> <details> <summary>βœ… πŸ“š Example README</summary> <details> <summary>πŸ€– STACKIT Model Serving</summary> βœ… Example READMEs are complete. </details> </details> <details> <summary>⚠️ πŸ’¬ Commit Messages</summary> <details> <summary>πŸ€– STACKIT Model Serving</summary> - "fix(ske): refactor observability logs with alloy | adjust agents.md" β†’ Suggest: "Refactor SKE observability logs to use Alloy and update agents.md documentation" - "fix(ske): refactor observability logs with alloy" β†’ Suggest: "Refactor SKE observability logging to integrate Alloy for improved metrics and tracing" </details> </details> <details> <summary>βœ… 🏷️ Tag Quality</summary> <details> <summary>πŸ€– STACKIT Model Serving</summary> - The tag `promtail` in the README.md should be replaced with `alloy` to accurately reflect the current log shipping agent used. - The tag list is otherwise accurate and covers the STACKIT products (ske, observability) and key technologies (logging, alerting, kubernetes). - All tags are lowercase and hyphen-separated. βœ… README tags accurately reflect the content. </details> </details> --- _Generated automatically β€” treat as a hint, not a gate._

LGTM! Thx

LGTM! Thx
mauritz.uphoff deleted branch fix/observability-log-alloy 2026-09-25 06:06:36 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
professional-service-best-practices/professional-service!79
No description provided.